libxl: fix assertion failure in stub domain creation
authorPaul Durrant <pdurrant@amazon.com>
Wed, 5 Feb 2020 11:24:12 +0000 (11:24 +0000)
committerWei Liu <wl@xen.org>
Wed, 5 Feb 2020 11:56:27 +0000 (11:56 +0000)
commitd00377890a3c62e0e925d171b6b839406b6d134d
tree2f8e9e1a9a0b01208cd95d535fda852d40678406
parentf7fb9a0aa9fbb81292e1626ce40340d3f6d8d505
libxl: fix assertion failure in stub domain creation

An assertion in libxl__domain_make():

'soft_reset || *domid == INVALID_DOMID'

does not hold true for stub domain creation, where soft_reset is false
but the passed in domid == 0. This is easily fixed by changing the
initializer in libxl__spawn_stub_dm().

NOTE: The comment for XEN_DOMCTL_createdomain in domctl.h is changed to
      reflect reality.

Fixes: 75259239d85d ("libxl_create: make 'soft reset' explicit")
Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
tools/libxl/libxl_dm.c
xen/include/public/domctl.h